-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide computed margins in full-json export #5203
Conversation
I'd like this key to be called Also, we need an entry in the schema for this new key, so that the Python codegen adds the property accessors and so it appears in the reference documentation etc etc. |
Overall this looks good, but I'm seeing some odd behaviour with a figure like this one: https://codepen.io/nicolaskruchten/pen/wvWBmyQ here the long x label is causing some automargin edge case: the right margin is increased because of the slanted label, but the bottom margin would exceed the cutoff so it resets. This is a known problem with automargins, and we don't need to tackle it now BUT the computed margin still shows |
Here is a minimal codepen to illustrate the bug you mentioned. |
I haven't poked too much at when exactly it happens, sorry. Can we fix it in the case that I identified? |
Given that the issue already exists in |
Let's merge this as-is for release in 1.57 for our sponsor, and then open a separate issue for the |
💃 merging then... |
Resolves #5185.
@plotly/plotly_js