keep null in x,y so regl knows the end of polygon

[ruijin]

Fixes #2291

[archmoj]

Thanks very much for the PR! 🥇
Could you please add a mock and baseline to our image tests similar to this codepen?
#2291 (comment)

Here is more info https://github.com/plotly/plotly.js/blob/master/CONTRIBUTING.md#image-pixel-comparison-tests

[archmoj]

Unfortunately these changes do not appear to fix the problem on this codepen.
@ruijin could you guide me to a case (data/layout) where your patch fixed the problem, please?

[ruijin]

I will try to provide a case. But just in case, did you test it together with the regl-line2d PR I submitted together? gl-vis/regl-line2d#49

[ruijin]

I modify the existing gl2d_scatter_fill_self_next test to add test with >2 segment, which exposes the issue. Below is the screen shot on my local run before and after the fix. You will need the PR in regl (gl-vis/regl-line2d#49) to see it.

Before

After

[archmoj]

I will try to provide a case. But just in case, did you test it together with the regl-line2d PR I submitted together? gl-vis/regl-line2d#49

Please edit the link for regl-line2d in package.json
So instead of

"regl-line2d": "^3.0.18",

you should provide the last commit hash and address to your fork of regl-line2d which is

"regl-line2d": "git://github.com/ruijin/regl-line2d.git#5d544746bbbcf09223281a0da5549a485782ffe1",

Then run npm install so that package-lock.json is updated.
Finally please commit the changes to package.json and package-lock.json files and push.

[ruijin]

The CI kept failing at random place, it does seem like triggered by the code I touched?

[archmoj]

The CI kept failing at random place, it does seem like triggered by the code I touched?

I rerun the tests. The jasmine ones now pass. But there is a problem catch by image test.
Could you investigate why gl2d_scatter_fill_self_next does not render when making the baseline?

[ruijin]

The issue of baseline is that I used Array.findIndex in the new code, and the image test server used by the test framework is a bit old and does not support that. So I use a polyfill instead. It should be fixed now.

[ruijin]

update regl-line2d to latest official version

[archmoj]

Nicely done.
💃