Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop legacy polar #5399

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Drop legacy polar #5399

merged 2 commits into from
Jan 13, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 13, 2021 •
edited
Loading

Addresses #5395,
This PR drops legacy polar and area trace.
It also drops t and r from the scatter trace and drops layout.radialaxis as well as layout.angularaxis attributes.

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jan 13, 2021
alexcjohnson
alexcjohnson reviewed Jan 13, 2021
View reviewed changes
test/jasmine/tests/mock_test.js
@@ -6,7 +6,6 @@ var list = [
'4',
'5',
'6',
'7',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And delete 6 and 8 (and their commented-out lines below), right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should verify that all the @noCI tests still run before we merge this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye.
Done in de6ca39.
And validated before submitting the PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OIC, this line will skip missing figures

plotly.js/test/jasmine/tests/mock_test.js

Line 2178 in 1529f3b

if(figure) {

That seems a little dangerous, but doesn't need to be addressed now.

alexcjohnson
alexcjohnson approved these changes Jan 13, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 that's a nice big 🔪 !!

@archmoj archmoj merged commit 4865393 into master Jan 13, 2021
@archmoj archmoj deleted the legacy-polar-cleanup branch January 13, 2021 23:15
This was referenced Jan 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson