Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer attach _has plot types to fullLayout #5409

Merged
merged 1 commit into from
Jan 15, 2021
Merged

No longer attach _has plot types to fullLayout #5409

merged 1 commit into from
Jan 15, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 15, 2021

Possibly used to be applied in streambed
cc: @dmt0
cc: #5395

@plotly/plotly_js

@dmt0
Copy link
Contributor

dmt0 commented Jan 15, 2021

Only in legacy code, so we should be good.

alexcjohnson
alexcjohnson approved these changes Jan 15, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking @dmt0 - looks good @archmoj 💃

@archmoj archmoj merged commit d430b84 into master Jan 15, 2021
@archmoj archmoj deleted the layout-has-cleanup branch January 15, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archmoj @dmt0 @alexcjohnson