Add strict partial bundles #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- does not depend on function constructors
tasks/stats.js
Outdated
| @@ -136,6 +136,8 @@ function getMainBundleInfo() { | |||
| 'Starting in `v1.39.0`, each plotly.js partial bundle has a corresponding npm package with no dependencies.', | |||
| '', | |||
| 'Starting in `v1.50.0`, the minified version of each partial bundle is also published to npm in a separate "dist min" package.', | |||
| '', | |||
| 'Starting in `v2.0.0`, the strict partial bundle includes everything except the traces that require function constructor.', | |||
There was a problem hiding this comment.
@nicolaskruchten Do we want to add something like "Over time we hope to include more of the remaining trace types here, after which we intend to work on other strict CSP issues such as inline CSS that we may not be able to include in the main bundle."
There was a problem hiding this comment.
@alexcjohnson
Good call.
Done in c0a3d92.
|
Does this PR include the lock-down test that fails if function constructors slip into the |
Yes it does. Whatever |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes everything (all the trace types) not depending on function constructors in respect to #897.
Unlike other partial bundles,
calendarswould also be included in these bundles.cc: #5395
@plotly/plotly_js