Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop various methods from Plotly.Fx and Plotly.Plots in the API #5420

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Drop various methods from Plotly.Fx and Plotly.Plots in the API #5420

merged 3 commits into from
Jan 19, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 18, 2021

Addressing part 2 of #5395 (comment)

@plotly/plotly_js

@dmt0 is there any of the removed methods used in streambed?

@archmoj archmoj added this to the NEXT milestone Jan 18, 2021
@dmt0
Copy link
Contributor

dmt0 commented Jan 19, 2021

A lot of methods from plotly.Plot are used in embedplot and in plotlyjs bundle and in the webapp.
I see the following being used:

embedplot:
.addLinks

plotlyjs:
.graphJson
.supplyDefaults
._supplyDefaults
.layoutAttributes
.fontWeight
.supplyLayoutGlobalDefaults

webapp:
._supplyDefaults
.cleanPlot

@alexcjohnson
Copy link
Collaborator

@dmt0 looks as though in streambed we re-export Plotly.Plots here (and anyway _supplyDefaults is created in that file) so AFAICT CS won't be affected.

alexcjohnson
alexcjohnson approved these changes Jan 19, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks great!

@archmoj archmoj merged commit 9b30fea into master Jan 19, 2021
@archmoj archmoj deleted the simplify-Fx-and-Plots-APIs branch January 19, 2021 18:57
@alexcjohnson alexcjohnson mentioned this pull request Jul 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@nicolaskruchten nicolaskruchten Awaiting requested review from nicolaskruchten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@archmoj @dmt0 @alexcjohnson