Drop Plotly.Queue from the API #5423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this an inbuilt undo/redo queue? Let's not get rid of it altogether, although hiding the API makes sense to me. |
test/jasmine/tests/plot_api_test.js
Outdated
| if(!Plotly.Queue) { | ||
| Plotly.Queue = { | ||
| if(!Queue) { | ||
| Queue = { |
There was a problem hiding this comment.
Seems like this fallback must be useless at this point?
There was a problem hiding this comment.
Seems so.
Addressed in 0cac2f5.
alexcjohnson
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Looks good, just the one test comment then I think this is good to go. 💃
@nicolaskruchten this queue is only populated by restyle and relayout, not react. I agree that we shouldn't remove its internals yet, though if nobody objects after using v2 I think we can do that as a followup to simplify and save some bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: #5395
@plotly/plotly_js
@alexcjohnson Shoud we remove
lib/queueas well?