Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leave no whitespace in compress_attributes when removing an attribute #5429

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Leave no whitespace in compress_attributes when removing an attribute #5429

merged 2 commits into from
Jan 21, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 21, 2021

Like

noWhiteSpace

Complete temporary diff dist commit: f5fafa7

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jan 21, 2021
alexcjohnson
alexcjohnson approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 💃

@archmoj archmoj merged commit f852131 into master Jan 21, 2021
@archmoj archmoj deleted the no-whitespace-in-compress-attrs branch January 25, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson