Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split header task into two tasks for dist and sources #5436

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Split header task into two tasks for dist and sources #5436

merged 2 commits into from
Jan 27, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 22, 2021

adds a task for the dist folder;
adds a task for the src and the lib folders;

  • at build time only runs header-dist
  • at publish time only commits version.js from the src
  • at new year simply run npm run header-src and it will no longer touch the dist folder so you could commit all the changes without excluding dist.

@plotly/plotly_js

@archmoj
split header task into two tasks one for source files the other for dist
499cda0 
- at build time only run header-dist
- at publish time only commit version.js from the src
- with a new year simply run header-src and it will not touch the dist
@archmoj archmoj added this to the NEXT milestone Jan 22, 2021
@archmoj archmoj requested a review from alexcjohnson January 25, 2021 15:04
alexcjohnson
alexcjohnson reviewed Jan 25, 2021
View reviewed changes
tasks/header_dist.js Outdated Show resolved Hide resolved
@archmoj
Copy link
Contributor Author

archmoj commented Jan 26, 2021

Also openend https://github.com/plotly/dev-docs/pull/177.

alexcjohnson
alexcjohnson approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 As discussed we plan to remove the src headers entirely, but this is a good first step.

@archmoj archmoj merged commit ccdd29a into master Jan 27, 2021
@archmoj archmoj deleted the improve-headers-update branch January 27, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson