Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add links to changelog, finally #5469

Merged
merged 4 commits into from
Feb 4, 2021
Merged

add links to changelog, finally #5469

merged 4 commits into from
Feb 4, 2021

Conversation

nicolaskruchten
Copy link
Contributor

Can we please do this moving forward? It's a real pain right now to actually navigate from the changelog to the PRs :)

@archmoj
Copy link
Contributor

archmoj commented Feb 4, 2021

It looks useful especially on the forks of plotly.js.

@archmoj
Copy link
Contributor

archmoj commented Feb 4, 2021

On this page: https://github.com/plotly/plotly.js/blob/changelog_links/CHANGELOG.md
it appears clicking on the links does not move to the place where we want to go!

@archmoj
Copy link
Contributor

archmoj commented Feb 4, 2021

On this page: https://github.com/plotly/plotly.js/blob/changelog_links/CHANGELOG.md
it appears clicking on the links does not move to the place where we want to go!

Basically we need to replace
https://github.com/plotly/plotly.js/pulls/# with
https://github.com/plotly/plotly.js/pull/

@nicolaskruchten
Copy link
Contributor Author

fixed

@alexcjohnson
Copy link
Collaborator

That's half of it, still needs pulls -> pull 😁

@nicolaskruchten
Copy link
Contributor Author

🤦 I swear I know how to do this!

@nicolaskruchten
Copy link
Contributor Author

It looks useful especially on the forks of plotly.js.

why? the #numbers don't work in this repo either :)

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 😍

@alexcjohnson
Copy link
Collaborator

It looks useful especially on the forks of plotly.js.

why? the #numbers don't work in this repo either :)

I think @archmoj was just agreeing with what you're doing here :)

@nicolaskruchten nicolaskruchten merged commit b749ced into master Feb 4, 2021
@archmoj archmoj deleted the changelog_links branch February 4, 2021 14:57
@archmoj archmoj added this to the NEXT milestone Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants