Split syntax task and run no-es6-dist on true publish files #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
Feb 4, 2021
| }); | ||
|
|
||
| var files = constants.partialBundlePaths.map(function(f) { return f.dist; }); | ||
| files.unshift(constants.pathToPlotlyDist); |
There was a problem hiding this comment.
Note I removed build from this line:
files.unshift(constants.pathToPlotlyBuild, constants.pathToPlotlyDist);
alexcjohnson
reviewed
Feb 4, 2021
| } else { | ||
| console.log('ok ' + name); | ||
| } | ||
| } |
There was a problem hiding this comment.
🌴 Can we pull this out into something like ./util/log? I see it changes EXIT_CODE but we can just return 1 and call it like EXIT_CODE += log('es5-only syntax', errors);
alexcjohnson
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we run es5 syntax test on current dist folder not target dist.
That's another reason why we noticed a problem after
v2.0.0-rc.0as mentioned in #5466.This PR fixes that problem and it is also helpful when we transfer
dist/topojsonanddist/extrastovendor.@plotly/plotly_js