Label flaky tests and add early returns in setTimeout functions to bypass undefined fullLayouts #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
reviewed
Feb 9, 2021
src/plots/cartesian/index.js
Outdated
| @@ -126,6 +126,7 @@ exports.finalizeSubplots = function(layoutIn, layoutOut) { | |||
| */ | |||
| exports.plot = function(gd, traces, transitionOpts, makeOnCompleteCallback) { | |||
| var fullLayout = gd._fullLayout; | |||
| if(!fullLayout._subplots) return; | |||
There was a problem hiding this comment.
What's this about? When do we encounter this?
There was a problem hiding this comment.
Sometimes happen at the end of transition_test with an error similar to the image below:
There was a problem hiding this comment.
archmoj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is improving the success rate of
test-jasminecontainer mainly by taggingflakytest so that they runtest-jasmine3container and reduce overall failures.@plotly/plotly_js