Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create vendor folder and fresh dist as a target only without extras including mathjax #5487

Merged
merged 18 commits into from
Feb 10, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Feb 9, 2021

Following the previous conversation on slack,
it seems reasonable (and less confusing) to move extras/mathjax and topojson to vendor folder and start a fresh dist.

TODOs:

  • figure out if all/any of the dist files we want to keep in the dist e.g. dist/README.md
  • rewrite the requirejs added in Test plotly.min.js in Require.js environment #914 so that it does not depend on the old build in dist and really tests what it should test

Next steps:

  • Remove mathjax from vendor and create a script to download, complete and update MathJax-v2 files from v2.3 to 2.7.x

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Feb 9, 2021
@archmoj archmoj changed the title Create vendor folder and fresh dist Create vendor folder and fresh dist as a target only without extras including mathjax Feb 9, 2021
@@ -132,6 +133,7 @@
"browserify": "^17.0.0",
"browserify-transform-tools": "^1.7.0",
"bubleify": "^2.0.0",
"canvas": "^2.6.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archmoj archmoj requested a review from alexcjohnson February 10, 2021 21:52
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks great - thanks for bringing back (and fixing) the requirejs test!

@archmoj archmoj merged commit 372bf82 into master Feb 10, 2021
@archmoj archmoj deleted the start-vendor-end-dist branch February 10, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants