Use topojson input from node_modules/sane-topojson #5492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devtools/test_dashboard/devtools.js
Outdated
| @@ -5,6 +5,7 @@ | |||
| var Fuse = require('fuse.js/dist/fuse.common.js'); | |||
| var mocks = require('../../build/test_dashboard_mocks.json'); | |||
| var credentials = require('../../build/credentials.json'); | |||
| var constants = require('@src/plots/geo/constants'); | |||
There was a problem hiding this comment.
don't you want tasks/util/constants?
There was a problem hiding this comment.
This is exactly the same as what is used in geo_test
There was a problem hiding this comment.
You are right. We are not really using local files here and in geo_test on this branch.
There was a problem hiding this comment.
Good catch!
Fixed in 343faa8.
archmoj
commented
Feb 11, 2021
devtools/test_dashboard/devtools.js
Outdated
| @@ -19,7 +19,7 @@ var Tabs = { | |||
| Plotly.setPlotConfig({ | |||
|
|
|||
| // use local topojson files | |||
| topojsonURL: '../../vendor/topojson/', | |||
| topojsonURL: '/node_modules/sane-topojson/dist/', | |||
There was a problem hiding this comment.
Or it should be
topojsonURL: '../../node_modules/sane-topojson/dist/',?
There was a problem hiding this comment.
Addressed in 815d047.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
topojsonfiles fromvendorfolder to avoid duplicates on (distandvendor) and simplify build process by using raw files fromsane-topojson/distiwithinnode_modulesfolder.@plotly/plotly_js