-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise process of making bundles and simplify making partial bundles #5508
Changes from 7 commits
4bbe89a
c3a8b48
4f862ca
e4c2f86
836248c
01136b7
aeaf709
c937a6f
d29446e
df67243
4772f90
e1c4cc3
8d902aa
0d00c52
a66d56a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/transforms/aggregate instead of lib/aggregate | ||
module.exports = require('../src/transforms/aggregate'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/bar instead of lib/bar | ||
module.exports = require('../src/traces/bar'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/barpolar instead of lib/barpolar | ||
module.exports = require('../src/traces/barpolar'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/box instead of lib/box | ||
module.exports = require('../src/traces/box'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/components/calendars instead of lib/calendars | ||
module.exports = require('../src/components/calendars'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/candlestick instead of lib/candlestick | ||
module.exports = require('../src/traces/candlestick'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/carpet instead of lib/carpet | ||
module.exports = require('../src/traces/carpet'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/choropleth instead of lib/choropleth | ||
module.exports = require('../src/traces/choropleth'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/choroplethmapbox instead of lib/choroplethmapbox | ||
module.exports = require('../src/traces/choroplethmapbox'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/cone instead of lib/cone | ||
module.exports = require('../src/traces/cone'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/contour instead of lib/contour | ||
module.exports = require('../src/traces/contour'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/contourcarpet instead of lib/contourcarpet | ||
module.exports = require('../src/traces/contourcarpet'); |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/densitymapbox instead of lib/densitymapbox | ||
module.exports = require('../src/traces/densitymapbox'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/transforms/filter instead of lib/filter | ||
module.exports = require('../src/transforms/filter'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/funnel instead of lib/funnel | ||
module.exports = require('../src/traces/funnel'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/funnelarea instead of lib/funnelarea | ||
module.exports = require('../src/traces/funnelarea'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/transforms/groupby instead of lib/groupby | ||
module.exports = require('../src/transforms/groupby'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/heatmap instead of lib/heatmap | ||
module.exports = require('../src/traces/heatmap'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/heatmapgl instead of lib/heatmapgl | ||
module.exports = require('../src/traces/heatmapgl'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/histogram instead of lib/histogram | ||
module.exports = require('../src/traces/histogram'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/histogram2d instead of lib/histogram2d | ||
module.exports = require('../src/traces/histogram2d'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/histogram2dcontour instead of lib/histogram2dcontour | ||
module.exports = require('../src/traces/histogram2dcontour'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
'use strict'; | ||
|
||
// deprecated in plotly.js v2 - one may use src/traces/image instead of lib/image | ||
module.exports = require('../src/traces/image'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,16 @@ | ||
'use strict'; | ||
|
||
var Plotly = require('./core'); | ||
var core = require('../src/core'); | ||
|
||
Plotly.register([ | ||
require('./bar'), | ||
require('./pie') | ||
core.register([ | ||
require('../src/traces/bar'), | ||
require('../src/traces/pie'), | ||
|
||
require('../src/transforms/aggregate'), | ||
require('../src/transforms/filter'), | ||
require('../src/transforms/groupby'), | ||
require('../src/transforms/sort'), | ||
require('../src/components/calendars') | ||
]); | ||
|
||
module.exports = require('./register_extra')(Plotly); | ||
module.exports = (function(Plotly) { return Plotly; })(core); | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,25 @@ | ||
'use strict'; | ||
|
||
var Plotly = require('./core'); | ||
var core = require('../src/core'); | ||
|
||
Plotly.register([ | ||
require('./bar'), | ||
require('./box'), | ||
require('./heatmap'), | ||
require('./histogram'), | ||
require('./histogram2d'), | ||
require('./histogram2dcontour'), | ||
require('./image'), | ||
require('./pie'), | ||
require('./contour'), | ||
require('./scatterternary'), | ||
require('./violin') | ||
core.register([ | ||
require('../src/traces/bar'), | ||
require('../src/traces/box'), | ||
require('../src/traces/heatmap'), | ||
require('../src/traces/histogram'), | ||
require('../src/traces/histogram2d'), | ||
require('../src/traces/histogram2dcontour'), | ||
require('../src/traces/contour'), | ||
require('../src/traces/scatterternary'), | ||
require('../src/traces/violin'), | ||
require('../src/traces/image'), | ||
require('../src/traces/pie'), | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As you can see, |
||
require('../src/transforms/aggregate'), | ||
require('../src/transforms/filter'), | ||
require('../src/transforms/groupby'), | ||
require('../src/transforms/sort'), | ||
require('../src/components/calendars') | ||
]); | ||
|
||
module.exports = require('./register_extra')(Plotly); | ||
module.exports = (function(Plotly) { return Plotly; })(core); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,23 @@ | ||
'use strict'; | ||
|
||
var Plotly = require('./core'); | ||
var core = require('../src/core'); | ||
|
||
Plotly.register([ | ||
require('./bar'), | ||
require('./histogram'), | ||
require('./pie'), | ||
require('./funnelarea'), | ||
require('./ohlc'), | ||
require('./candlestick'), | ||
require('./funnel'), | ||
require('./waterfall'), | ||
require('./indicator') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As you can see, |
||
core.register([ | ||
require('../src/traces/bar'), | ||
require('../src/traces/histogram'), | ||
require('../src/traces/funnel'), | ||
require('../src/traces/waterfall'), | ||
require('../src/traces/pie'), | ||
require('../src/traces/funnelarea'), | ||
require('../src/traces/indicator'), | ||
require('../src/traces/ohlc'), | ||
require('../src/traces/candlestick'), | ||
|
||
require('../src/transforms/aggregate'), | ||
require('../src/transforms/filter'), | ||
require('../src/transforms/groupby'), | ||
require('../src/transforms/sort'), | ||
require('../src/components/calendars') | ||
]); | ||
|
||
module.exports = require('./register_extra')(Plotly); | ||
module.exports = (function(Plotly) { return Plotly; })(core); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,16 @@ | ||
'use strict'; | ||
|
||
var Plotly = require('./core'); | ||
var core = require('../src/core'); | ||
|
||
Plotly.register([ | ||
require('./scattergeo'), | ||
require('./choropleth') | ||
core.register([ | ||
require('../src/traces/scattergeo'), | ||
require('../src/traces/choropleth'), | ||
|
||
require('../src/transforms/aggregate'), | ||
require('../src/transforms/filter'), | ||
require('../src/transforms/groupby'), | ||
require('../src/transforms/sort'), | ||
require('../src/components/calendars') | ||
]); | ||
|
||
module.exports = require('./register_extra')(Plotly); | ||
module.exports = (function(Plotly) { return Plotly; })(core); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,19 @@ | ||
'use strict'; | ||
|
||
var Plotly = require('./core'); | ||
|
||
Plotly.register([ | ||
require('./scattergl'), | ||
require('./splom'), | ||
require('./pointcloud'), | ||
require('./heatmapgl'), | ||
require('./parcoords') | ||
var core = require('../src/core'); | ||
|
||
core.register([ | ||
require('../src/traces/scattergl'), | ||
require('../src/traces/splom'), | ||
require('../src/traces/pointcloud'), | ||
require('../src/traces/heatmapgl'), | ||
require('../src/traces/parcoords'), | ||
|
||
require('../src/transforms/aggregate'), | ||
require('../src/transforms/filter'), | ||
require('../src/transforms/groupby'), | ||
require('../src/transforms/sort'), | ||
require('../src/components/calendars') | ||
]); | ||
|
||
module.exports = require('./register_extra')(Plotly); | ||
module.exports = (function(Plotly) { return Plotly; })(core); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,21 @@ | ||
'use strict'; | ||
|
||
var Plotly = require('./core'); | ||
|
||
Plotly.register([ | ||
require('./scatter3d'), | ||
require('./surface'), | ||
require('./mesh3d'), | ||
require('./isosurface'), | ||
require('./volume'), | ||
require('./cone'), | ||
require('./streamtube') | ||
var core = require('../src/core'); | ||
|
||
core.register([ | ||
require('../src/traces/scatter3d'), | ||
require('../src/traces/surface'), | ||
require('../src/traces/isosurface'), | ||
require('../src/traces/volume'), | ||
require('../src/traces/mesh3d'), | ||
require('../src/traces/cone'), | ||
require('../src/traces/streamtube'), | ||
|
||
require('../src/transforms/aggregate'), | ||
require('../src/transforms/filter'), | ||
require('../src/transforms/groupby'), | ||
require('../src/transforms/sort'), | ||
require('../src/components/calendars') | ||
]); | ||
|
||
module.exports = require('./register_extra')(Plotly); | ||
module.exports = (function(Plotly) { return Plotly; })(core); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,17 @@ | ||
'use strict'; | ||
|
||
var Plotly = require('./core'); | ||
var core = require('../src/core'); | ||
|
||
Plotly.register([ | ||
require('./scattermapbox'), | ||
require('./choroplethmapbox'), | ||
require('./densitymapbox') | ||
core.register([ | ||
require('../src/traces/scattermapbox'), | ||
require('../src/traces/choroplethmapbox'), | ||
require('../src/traces/densitymapbox'), | ||
|
||
require('../src/transforms/aggregate'), | ||
require('../src/transforms/filter'), | ||
require('../src/transforms/groupby'), | ||
require('../src/transforms/sort'), | ||
require('../src/components/calendars') | ||
]); | ||
|
||
module.exports = require('./register_extra')(Plotly); | ||
module.exports = (function(Plotly) { return Plotly; })(core); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally it feels to me like this indirection makes things more confusing than the previous pattern - which with
register_extra
removed becomes just:Is there another reason for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
register_extra
file is not documented and confusing.Until we could bump d3 (cc: #5112) or possibly release a
@plotly/d3-v3
patch to fix unexpected characters at build time we need a function to the return correct result.