Fixup sankey text and shadow #5531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this helps increase readability on overlaps
|
Looks great - as discussed let's just prevent MathJax in Sankey with |
Addressed in 2f38a9d. |
alexcjohnson
reviewed
Mar 5, 2021
|
|
||
| nodeLabel | ||
| .style('text-shadow', function(d) { | ||
| return d.horizontal ? svgTextUtils.makeTextShadow(1, '#fff') : 'none'; | ||
| .attr('data-notex', 1) // prohibit tex interpretation until we can handle tex and regular text together |
There was a problem hiding this comment.
Nonblocking, but this isn't quite the rationale here, here we don't want tex because of shadows and positioning issues :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started out as a bugfix to take into account
paper_bgcolorissankeytext-shadow following #5506,We discovered that
textfont.colorwas not able to control the color of labels on asankeygraph!It addition to those fixes this PR resolves #3742.
One could also pass
MathJax; but (at the moment) the label positioning is not perfect in that case.Also vertical
sankeygraphs used to trim the text to force the labels inside the node.This behaviour is also changed in this PR and full labels are presented.
@plotly/plotly_js
cc: #5395