Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scattergl: make selection's eventData the same as in scatter traces #5534

Merged
merged 6 commits into from
Mar 8, 2021

Conversation

antoinerg
Copy link
Contributor

This PR makes scattergl traces return selection's eventData that's the same as in scatter.

Closes #5533

@archmoj archmoj added status: reviewable bug something broken labels Mar 4, 2021
@archmoj archmoj added this to the NEXT milestone Mar 4, 2021
@archmoj
Copy link
Contributor

archmoj commented Mar 4, 2021

Looks great!
@antoinerg are you going to test scatterpolar and scatterpolargl as well?

@antoinerg
Copy link
Contributor Author

Looks great!
@antoinerg are you going to test scatterpolar and scatterpolargl as well?

I didn't realize we also had categorical axes on scatterpolar plots 😮 . Yes, let me check those out!

@antoinerg
Copy link
Contributor Author

antoinerg commented Mar 4, 2021

In 4fd7070, I added a test to check that scatterpolargl and scatterpolar produce the same eventData.

I should mention that in both scatter and scatterpolar, the test coverage is not 100% as I only run the tests on one axis instead of both of them. Let me know if you want me to test both axes. The tests now 🔒 down the behavior on both axes for both scattergl and scatterpolargl.

@antoinerg antoinerg requested a review from archmoj March 5, 2021 16:34
@archmoj
Copy link
Contributor

archmoj commented Mar 6, 2021

Nicely done.
💃

@nicolaskruchten
Copy link
Contributor

Phew, good timing on this find and fix, right before 2.0 :)

@archmoj archmoj merged commit c288f57 into master Mar 8, 2021
@archmoj archmoj deleted the scattergl-fix-select branch March 8, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scattergl traces return selection's eventData that differs from scatter
3 participants