Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account inside labels of overlaid axes in autorange padding #5586

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 9, 2021

Addressing #5402.

This is the autorange part only.

There is also a hiding part which (to avoid conflicts) could be addressed (in a similar fashion by using ._plots info) after #5582 and #5584 get merged.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Apr 9, 2021
@archmoj archmoj added this to the NEXT milestone Apr 9, 2021
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Nice and clean 🎉

@archmoj archmoj merged commit c35e5c4 into master Apr 10, 2021
@archmoj archmoj deleted the fix5402-inside-ticks-on-overlaid-axes branch April 10, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants