Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account inside labels of the counter axis during autorange relayout #5610

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Take into account inside labels of the counter axis during autorange relayout #5610

merged 1 commit into from
Apr 27, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 26, 2021

Addressing #5601

@plotly/plotly_js

@archmoj
fix 5601
b676bc6 
 - get bounding box when undefined
 - bypass mathjax
 - add jasmine test
@archmoj archmoj added bug something broken status: reviewable labels Apr 26, 2021
@archmoj archmoj added this to the NEXT milestone Apr 26, 2021
alexcjohnson
alexcjohnson approved these changes Apr 27, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 💃

@archmoj archmoj merged commit a5a5de9 into master Apr 27, 2021
@archmoj archmoj deleted the fix5601 branch April 27, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson