Address scattergl performance issue with TypeArrays #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address an unavoidable loop phase inside color clean function where it iterates all over the graph points if data used is an ArrayBuffer. This causes graph to have way less performance relative to Array types.
archmoj
reviewed
May 5, 2021
src/components/color/index.js
Outdated
| @@ -116,7 +116,7 @@ color.clean = function(container) { | |||
| if(!Array.isArray(el0) && el0 && typeof el0 === 'object') { | |||
| for(j = 0; j < val.length; j++) color.clean(val[j]); | |||
| } | |||
| } else if(val && typeof val === 'object') color.clean(val); | |||
| } else if(val && typeof val === 'object' && !ArrayBuffer.isView(val)) color.clean(val); | |||
There was a problem hiding this comment.
Let's only allow typed arrays here by using the isTypedArray function.
Lines 8 to 11 in 65f739d
To use that you could require it like this:
var isTypedArray = require('../../lib/array').isTypedArray;
Seranicio
changed the title
archmoj
changed the title
|
Thanks very much for the PR. |
|
Does this PR fully resolve #4401 i.e. the part about line-decimation or just the part about Arrays? |
No. I reopened the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address: #4401
Overview of the Pull Request:
Address an unavoidable loop phase inside color clean function where
it iterates all over the graph points if data used is a derivative of a ArrayBuffer.
This causes graph to have way less performance relative to Array types.
Also added a little performance enhancement to calc function. Tell if this is out of scope :)
Simple Demo: here (adapted from @archmoj)
Function performance checkup: