Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate transform attributes #5657

Merged
merged 3 commits into from
May 14, 2021
Merged

Deprecate transform attributes #5657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05a74d9
deprecate transform attributes
archmoj May 14, 2021
d36e650
add warning for deprecated transforms
archmoj May 14, 2021
31073ab
place deprecated warnings in calendars transform descriptions
archmoj May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/calendars/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,11 @@ module.exports = {
transforms: {
filter: {
valuecalendar: makeAttrs([
'WARNING: All transforms are deprecated and may be removed from the API in next major version.',
'Sets the calendar system to use for `value`, if it is a date.'
].join(' ')),
targetcalendar: makeAttrs([
'WARNING: All transforms are deprecated and may be removed from the API in next major version.',
'Sets the calendar system to use for `target`, if it is an',
'array of dates. If `target` is a string (eg *x*) we use the',
'corresponding trace attribute (eg `xcalendar`) if it exists,',
Expand Down
1 change: 1 addition & 0 deletions src/plots/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ module.exports = {
_isLinkedToArray: 'transform',
editType: 'calc',
description: [
'WARNING: All transforms are deprecated and may be removed from the API in next major version.',
'An array of operations that manipulate the trace data,',
'for example filtering or sorting the data arrays.'
].join(' ')
Expand Down