Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bar get color #5666

Merged
merged 2 commits into from
May 19, 2021
Merged

Fix bar get color #5666

merged 2 commits into from
May 19, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 18, 2021

Fixes plotly/plotly.py#3196.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels May 18, 2021
@archmoj archmoj added this to the NEXT milestone May 18, 2021
@nicolaskruchten nicolaskruchten mentioned this pull request May 19, 2021
Closed
alexcjohnson
alexcjohnson approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, nice test! 💃

@archmoj archmoj merged commit 2b58ca2 into master May 19, 2021
@archmoj archmoj deleted the fix-bar-get-color-mcc branch May 19, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

non-dynamic textfont color when using continuous color scales
2 participants
@archmoj @alexcjohnson