Revise attributions of Carto, Stamen and Open Street Map styles #5696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAICT only the Carto attributions should change, the Stamen ones were already using the correct attributions as described in http://maps.stamen.com/. They're a little long, but feels to me as though we should stick to their desired attributions. |
|
For Carto, just add whatever OSM requires :) |
archmoj
commented
Jun 1, 2021
| @@ -1487,6 +1548,11 @@ describe('mapbox plots', function() { | |||
| var s = d3SelectAll('.mapboxgl-ctrl-attrib'); | |||
| expect(s.size()).toBe(1); | |||
| expect(s.text()).toEqual('© Mapbox © OpenStreetMap Improve this map'); | |||
| assertLinks(s, [ | |||
| 'https://www.mapbox.com/about/maps/', | |||
| 'http://www.openstreetmap.org/about/', | |||
There was a problem hiding this comment.
@alexcjohnson any suggestion on how to replace this http link with https?
There was a problem hiding this comment.
if this is coming from MapboxGL.js let's just leave it for now
There was a problem hiding this comment.
Yeah. It's coming from there.
archmoj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5675.
@plotly/plotly_js