Separate command line script for making custom bundles and rename it to "custom-bundle" #5712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- that way custom-bundle may include extra things that are not in the main - also avoids problem when adding command line options to extra_bundle - add command line option to help rebuild specific extra_bundles e.g. gl3d
alexcjohnson
approved these changes
Jun 4, 2021
It would also unlock better testing of those partial bundles (in future) on the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds command line option to
extra_bundlesscript to specify which dist bundles to generate/update.Also makes
custom-bundlescript a separate script which would allow adding command line options toextra_bundlesscript e.g. to rebuildstrictand/orgl3d(as added by this PR).Also it is important to note that
custom-bundlemay be used to include features (e.g. traces, transforms) that are not in the main bundle in future.So it is better to name it this way instead of
partial_bundlewhich is now an internal module.@plotly/plotly_js