🐛 fix(line): prevent Line Chart from crashing when having no data (#2669

) * fix + test * test refacto
plouc · Nov 15, 2024 · cdf60f7 · cdf60f7
1 parent 78a63f9
commit cdf60f7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/packages/line/tests/Line.test.js b/packages/line/tests/Line.test.js
@@ -435,7 +435,7 @@ describe('mouse events on slices', () => {
     })
 })
 
-describe('touch events with useMesh', () => {
+describe('events with useMesh', () => {
     const data = [
         {
             id: 'A',
@@ -457,13 +457,26 @@ describe('touch events with useMesh', () => {
         enableTouchCrosshair: true,
     }
 
+    it('should not throw onMouseEnter on empty data', () => {
+        const onMouseEnter = jest.fn()
+        const wrapper = mount(<Line {...baseProps} data={[]} onMouseEnter={onMouseEnter} />)
+        expect(() =>
+            wrapper.find(`[data-ref='mesh-interceptor']`).simulate('mouseenter', {
+                clientX: 50,
+                clientY: 50,
+            })
+        ).not.toThrow()
+        wrapper.unmount()
+    })
+
     it('should call onTouchStart', () => {
         const onTouchStart = jest.fn()
         const wrapper = mount(<Line {...baseProps} onTouchStart={onTouchStart} />)
         wrapper.find(`[data-ref='mesh-interceptor']`).simulate('touchstart', {
             touches: [{ clientX: 50, clientY: 50 }],
         })
         expect(onTouchStart).toHaveBeenCalledTimes(1)
+        wrapper.unmount()
     })
 
     it('should call onTouchMove', () => {
@@ -473,6 +486,7 @@ describe('touch events with useMesh', () => {
             touches: [{ clientX: 50, clientY: 50 }],
         })
         expect(onTouchMove).toHaveBeenCalledTimes(1)
+        wrapper.unmount()
     })
 
     it('should call onTouchEnd', () => {
@@ -485,6 +499,7 @@ describe('touch events with useMesh', () => {
             })
             .simulate('touchend')
         expect(onTouchEnd).toHaveBeenCalledTimes(1)
+        wrapper.unmount()
     })
 })
 

diff --git a/packages/voronoi/src/hooks.ts b/packages/voronoi/src/hooks.ts
@@ -171,7 +171,7 @@ export const useMeshEvents = <Node, ElementType extends Element>({
 
     const findNode = useCallback(
         (event: MouseEvent<ElementType> | TouchEvent<ElementType>): null | [number, Node] => {
-            if (!elementRef.current) return null
+            if (!elementRef.current || nodes.length === 0) return null
 
             const [x, y] = getRelativeCursor(elementRef.current, event)