Bars Overlap axis When minValue is greater than 0.

[ollwenjones]

Describe/explain the bug
If bar axis minimum is set much above 0, the bars extend off the edge of the chart and obscure the axis & its labels

To Reproduce
https://codesandbox.io/s/nivobar-chart-overlapping-axis-mod21?file=/src/index.js

Steps to reproduce the behavior:

1. Create a bar chart with either orientation.
2. Set minValue to be > 0. 20% or so of smallest entry works best to reproduce.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Desktop (please complete the following information):

• OS: Windows
• Browser Chrome
• Version 86

Additional context
I might be able to work around this in my app by adjusting the stack order...

[ollwenjones]

@plouc mentioned on discord we could clamp this except it's very complex given how flexible the bar behavior is (grouped vs stacked), (bars vs columns,) etc. It seems like it would be straightforward for grouped bars based on orientation. I can see how stacked values would make this more complex, though.

[wyze]

Adding logic in the scales package for clamp on the linearScale seems straight forward. Then you can pass valueProp={{ type: 'linear', clamp: true }} and get desired results. Minor tick overlapping on the right axis, but that's because you specified a 0 tick value so it is getting clamped to the 1 position.

[ollwenjones]

@wyze super cool. The specified tickValues were just something from the example I grabbed; nothing important. Is that something you did just there in codesandbox, or were there additional changes to the way Bar exposes its scales to do it?

[wyze]

Just a couple changes to scales package. Here

nivo/packages/scales/src/linearScale.js

Line 13 in 8451c27

{ axis, min = 0, max = 'auto', stacked = false, reverse = false },

add something like , clamp = false to the first parameter.

Then somewhere down here

nivo/packages/scales/src/linearScale.js

Line 34 in 8451c27

add if (clamp) { scale.clamp(true) }.

Update PropTypes in that linearScales file.

Update typings for scales package here

nivo/packages/scales/index.d.ts

Line 16 in 8451c27

}

with clamp?: boolean.

That should do it.

[ollwenjones]

That is about the friendliest indirect invitation to PR that I have ever received 😄

[wyze]

I wasn't sure if you wanted to contribute or not, don't feel pressured to do so. :)

[ollwenjones]

would love to. just racing towards a deadline at present. This is linked in our backlog, so it's not unlikely someone will circle back and contribute :D

[ollwenjones]

Hoping to have some time to contribute here, soon.