Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong peer dependencies in some packages like @nivo/funnel #1403

Closed
ohardy opened this issue Jan 28, 2021 · 0 comments · Fixed by #1486
Closed

Wrong peer dependencies in some packages like @nivo/funnel #1403

ohardy opened this issue Jan 28, 2021 · 0 comments · Fixed by #1486

Comments

@ohardy
Copy link

ohardy commented Jan 28, 2021

Currently in package.json in packages/funnel

"peerDependencies": {
    "@nivo/annotations": "0.63.1",
    "@nivo/colors": "0.63.0",
    "@nivo/core": "0.67.0",
    "@nivo/tooltip": "0.63.0",
    "prop-types": ">= 15.5.10 < 16.0.0",
    "react": ">= 16.8.4 < 18.0.0"
  },

I think most of @nivo/* peer dependencies should be at 0.67.0, no ?

Some other packages in the repo seem to have the same problem.

(Lerna doesn't update peer versions on version change)

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant