-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heatmap 0.79.0 colors string list breaking #1988
Comments
(I'm not an author/maintainer of nivo, but hope this can help) The heatmap component introduced several breaking changes in v0.79.0. See here. In practice, you can rescue your sandbox code by making two changes. First, change the data format from
to
Second, change how you provide custom colors to the heatmap.
This approach will use the colors given, without interpolation. As far as I can tell, custom color arrays are now supported by @plouc, what would you think about supporting sequential/diverging scales with custom colors? (I can have a look). Alternatively, perhaps the Heatmap could take a prop |
@tkonopka, yes, it would be nice to also support custom colors for those, but it's a bit more complex, I'm also ok with allowing to pass a pre-made color scale. |
Fixed by #1998 (but requires to use the new format to define colors). |
To Reproduce
https://codesandbox.io/s/empty-shadow-g4zu1c?file=/src/HeatmapChart.tsx
Steps to reproduce the behavior:
Expected behavior
should render without bug as it was in 0.78.0 version
Screenshots
additional
change to version 0.78.0 to see bug going out
The text was updated successfully, but these errors were encountered: