-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate @nivo/heatmap to TypeScript #1880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plouc
added
🎨 colors
🔥 heatmap
@nivo/heatmap package
legends
typescript
nivo core team
labels
Jan 6, 2022
plouc
changed the title
feat(colors): add support for continuous color scales
Migrate @nivo/heatmap to TypeScript
Jan 6, 2022
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4dc588e:
|
…IE support is needed
…ges and additions
plouc
force-pushed
the
heatmap-typescript
branch
from
January 6, 2022 22:07
2425c46
to
698a6ec
Compare
plouc
force-pushed
the
heatmap-typescript
branch
from
January 7, 2022 12:47
baa821d
to
9094fae
Compare
… full potential for the heatmap
…rolled where needed, for example the colors
… adding a new one on the interactive demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nivo/heatmap
:data
now takes a similar structure toAreaBump
,Bump
,Line
andScatterPlot
:therefore,
indexBy
andkeys
have been removed.colors
behaves completely differently, and now supportssequential
,diverging
andquantize
color scales, the best is to have a look at the interactive doc of the component and play with the various types to see how to use them.Root properties
minValue
andmaxValue
have been removed, we can now control this where needed (colors
andsizeVariation
).sizeVariation
now accepts eitherfalse
(to disable it) or a config object having the following structure:Renamed properties:
padding
→xOuterPadding
,xInnerPadding
,yOuterPadding
,yInnerPadding
cellBorderWidth
→borderWidth
cellBorderColor
→borderColor
cellOpacity
→opacity
cellHoverOpacity
→activeOpacity
cellHoverOthersOpacity
→inactiveOpacity
Also, the scope of this PR became huge 😅, so here is a summary:
@nivo/heatmap
:data
to use series like other charts to be able to use the same data structure for different chart types@nivo/colors
:sequential
,diverging
andquantize
@nivo/legends
:@nivo/core
:resize-observer-polyfill
package as it should be added only if IE support is needed@nivo/funnel
: