-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bars sizes are rounded and don't take the whole chart area #840
Comments
👍 |
Maybe not. Because coordinates on all other charts are float numbers |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
bump |
@constgen Can you provide a CodeSandbox demonstrating above, or close to it, so I can check it out against your proposed PR please? |
I will try |
Here is one that represents the issue: https://codesandbox.io/s/busy-violet-s19us |
This was added in #1282. You can use |
Bars lines in
Bar
chart do not cover all area of a chart (SVG element). Their sizes are rounded. That's why we can see gaps on the left and right. This screenshot shows this issue comparing Histograms with TimelineScreenshots
To reproduce this you can use for example
width=200
and 92 child itemsExpected behavior
Bars should take all space from left to right. The dimensions are integers
<g transform="translate(8, 20)">
. But float numbers are expectedDesktop (please complete the following information):
The text was updated successfully, but these errors were encountered: