Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't round a bar scale #841

Closed
wants to merge 2 commits into from
Closed

Conversation

constgen
Copy link

Fixes #840

@constgen
Copy link
Author

Snapshots tests failed. Please, help me to update them if you think that this PR doesn't brake anything.

@constgen constgen requested a review from plouc January 23, 2020 13:36
@stale
Copy link

stale bot commented Oct 29, 2020

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the stale label Oct 29, 2020
@constgen
Copy link
Author

bump

@stale stale bot removed the stale label Oct 31, 2020
@wyze
Copy link
Contributor

wyze commented Nov 12, 2020

@plouc Was there a specific reason to use rounded values for the index scale? Is this change going to be okay, or should we look into making some prop like indexScale={{ round: false }} that users can opt into?

@constgen
Copy link
Author

Because rounding is disabled for all other charts. More details in the referred issue.

@plouc
Copy link
Owner

plouc commented Nov 13, 2020

@wyze, @constgen I remember adding it for a specific use case I had, should maybe not be the default, but I think we should keep the option.

@constgen
Copy link
Author

Do you expect it to brake something?

@wyze
Copy link
Contributor

wyze commented Nov 18, 2020

This was added in #1282. You can use indexScale={{ type: 'band', round: false }}. This will be available in the next version.

@wyze wyze closed this Nov 18, 2020
@wyze
Copy link
Contributor

wyze commented Nov 18, 2020

Thanks for the contribution, and sorry it didn't work out landing it this way.

@constgen
Copy link
Author

The new option may help

@constgen constgen deleted the bars-dimensions branch November 21, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bars sizes are rounded and don't take the whole chart area
3 participants