Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sankey): Fix issue with gradient and parentheses in IDs #1152

Merged
merged 1 commit into from
Oct 10, 2020
Merged

fix(sankey): Fix issue with gradient and parentheses in IDs #1152

merged 1 commit into from
Oct 10, 2020

Conversation

JonathanPicques
Copy link
Contributor

Closes #1150

@JonathanPicques
Copy link
Contributor Author

It should work with ~everything (tested with ' " ` @ / \)

@wyze wyze changed the title Fix issue with gradient and parentheses in IDs fix(sankey): Fix issue with gradient and parentheses in IDs Oct 10, 2020
@wyze wyze merged commit 56f0e44 into plouc:master Oct 10, 2020
@wyze
Copy link
Contributor

wyze commented Oct 10, 2020

Thanks for the quick fix!

@snyk-bot snyk-bot mentioned this pull request Jul 6, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parentheses in Sankey node ids break link colors
2 participants
@JonathanPicques @wyze