Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar): Fix BarItemProps types #1163

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Conversation

eggei
Copy link
Contributor

@eggei eggei commented Oct 17, 2020

Fixes #1155

Changes:

  • Change data prop type to BarExtendedDatum
  • Remove color field in data prop's type - it doesn't exist in data prop
  • Create BarTooltipDatum to pass color type to tooltip props along with
    BarExtendedDatum
  • Add SVGRectElement to BarMouseEventHandler generic type
  • Update deprecated React.StatelessComponent to React.FC

- Change data prop type to BarExtendedDatum
- Remove color field in data prop's type - it doesn't exist in data prop
- Create BarTooltipDatum to pass color type to tooltip props along with
  BarExtendedDatum
- Add SVGRectElement to BarMouseEventHandler generic type
- Update deprecated React.StatelessComponent to React.FC
@eggei
Copy link
Contributor Author

eggei commented Oct 17, 2020

Hi @wyze - I created this PR after our conversation on the Discord channel. I can't request reviews for some reason, so I thought I can mention you here to let you know about this. Thank you!

packages/bar/index.d.ts Outdated Show resolved Hide resolved
@eggei eggei requested a review from wyze October 22, 2020 02:52
@wyze wyze changed the title Fix BarItemProps types fix(bar): Fix BarItemProps types Oct 22, 2020
@wyze wyze merged commit 7f19561 into plouc:master Oct 22, 2020
@wyze
Copy link
Contributor

wyze commented Oct 22, 2020

Thanks!

ddavydov pushed a commit to netronixgroup/nivo that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need for casting types over an over again in barComponent callback (TS)
2 participants