-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(calendar): enhanced calendar with month granularity support #1173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoiding reassigning the day parameter. Co-authored-by: Neil Kistner <[email protected]>
fixing reassigning value Co-authored-by: Neil Kistner <[email protected]>
Hi @plouc , how are you? Is there any expectation of when this PR will be merged? |
JaredPh
reviewed
Jan 28, 2021
Co-authored-by: Jared Phayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the #212
To avoid any breaking change and weird names, I created
EnhancedCalendar
,EnhancedCalendarCanvas
,ResponsiveEnhancedCalendar
andResponsiveEnhancedCalendarCanvas
which supportsgranularity
,breakpoint
andweekDirection
. The previous set of Calendar components stayed almost the same.In this set of components,
yearSpacing
,yearLegend
,yearLegendPosition
andyearLegendOffset
have been renamed toblockSpacing
,blockLegend
,blockLegendPosition
andblockLegendOffset
.While
yearLegend
receivesyear: number
,blockLegend
receives:There are some examples of the new functionalities as new stories in the storybook.
I tried my best to put shared code in a single file and specific code in different trees. This way, tree shaking should work and users of the normal
Calendar
should not see any increase in bundle size.Please, review thoroughly and check
index.d.ts
Cya!!