fix(axis): time series rendering #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: András Tóth <[email protected]>
tothandras
commented
Feb 2, 2021
| @@ -184,7 +184,7 @@ export const computeCartesianTicks = ({ | |||
| } | |||
|
|
|||
| const ticks = values.map(value => ({ | |||
| key: value, | |||
| key: typeof value === 'number' || typeof value === 'string' ? value : `${value}`, | |||
There was a problem hiding this comment.
This could also be just:
Suggested change
| key: typeof value === 'number' || typeof value === 'string' ? value : `${value}`, | |
| key: `${value}`, |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e73b2ab:
|
|
@plouc Please merge this, time scale is pretty much unusable otherwise. |
|
@plouc Is there any ETA on this fix to be release? |
|
Also running into this. Was pointed to this issue on the discord based on my issue reported here: #1468 |
This was referenced Apr 21, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1379
The transition uses an ever-incrementing key when the type of the provided key is a
Date.