fix(core): add missing marker typings #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `legendOrientation` & `legendPosition` to CartesianMarkerProps
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f4933d1:
|
wyze
changed the title
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview 🚀
Markers are missing two props in their type declarations,
legendOrientationandlegendPosition. Those props can be seen in use at nivo.rocks/adding-markers.legendPositionutilizes the type declared at line 20 -BoxAlign, whilelegendOrientationhas a hard coded union'horizontal' | 'vertical'.Additionally, line 168 reuses an already declared
DatumValuetype from line 5.Thanks for the sick dataviz component library 👍