fix(voronoi): length undefined in production #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sueannioanis
force-pushed
the
sue/fix-length-undefined
branch
from
d0dc967 to
6451552
Compare
sueannioanis
changed the title
sueannioanis
force-pushed
the
sue/fix-length-undefined
branch
from
6451552 to
91747a1
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3784924:
|
sueannioanis
force-pushed
the
sue/fix-length-undefined
branch
2 times, most recently
from
73630cc to
06b41cd
Compare
sueannioanis
force-pushed
the
sue/fix-length-undefined
branch
from
7c9688a to
3784924
Compare
sueannioanis
changed the title
sueannioanis
commented
Mar 10, 2021
| } | ||
|
|
||
| const poly = voronoi.cellPolygon(i) | ||
| const poly = voronoi.cellPolygon(i) || [] |
There was a problem hiding this comment.
Defaulting here fixes the error. For some reason, .cellPolygon is returning null sometimes. I could dig deeper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix unique key issues & length of undefined for
voronoi.Dev (Warning only shows in dev. The
undefinederror happens after a few seconds.):Prod (The
undefinederror happens after a few seconds.):Fix:
❤️ this project. i contributed in opencollective.com/nivo.