Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): avoid occasional "ResizeObserver loop" error #1466

Merged
merged 1 commit into from
May 22, 2021

Conversation

ollwenjones
Copy link
Contributor

This error is hard to reproduce, but it's a straightforward workaround to make sure the observer doesn't try to update when it can't within the given frame.

Some more context about the error, and reference for the workaround.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 14d04c0:

Sandbox Source
nivo Configuration
nivo-website Configuration

@ollwenjones ollwenjones force-pushed the resize-observer-error branch from 6dc5412 to 08ea2ca Compare April 5, 2021 21:25
packages/core/src/hooks/useMeasure.js Outdated Show resolved Hide resolved
This error is hard to reproduce, but it's a straightforward workaround
to make sure the observer doesn't try to update when it can't within
the given frame.
@ollwenjones ollwenjones force-pushed the resize-observer-error branch from 08ea2ca to 14d04c0 Compare May 21, 2021 15:59
Copy link
Contributor

@wyze wyze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@wyze wyze merged commit 7f88e10 into plouc:master May 22, 2021
wyze added a commit that referenced this pull request Jun 3, 2021
plouc pushed a commit that referenced this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants