Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(line): update type for custom line canvas layers #1499

Conversation

jguddas
Copy link
Contributor

@jguddas jguddas commented Apr 30, 2021

this resolves #1413

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 30, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6816c7d:

Sandbox Source
nivo Configuration
nivo-website Configuration

packages/line/index.d.ts Outdated Show resolved Hide resolved
@wyze wyze changed the title fixed typescript definition for custom line canvas layers fix(line): update type for custom line canvas layers May 1, 2021
@wyze wyze merged commit 0454784 into plouc:master May 1, 2021
@wyze
Copy link
Contributor

wyze commented May 1, 2021

Thanks @jguddas!

@jguddas
Copy link
Contributor Author

jguddas commented May 1, 2021

Awesome, thanks for the help and the quick me merge @wyze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom line canvas layers have different props then custom svg line layers
2 participants