Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add_typescript_to_calendar] enable type generation #1504

Closed
wants to merge 1 commit into from

Conversation

scherler
Copy link
Contributor

@scherler scherler commented May 3, 2021

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 61fc18c:

Sandbox Source
nivo Configuration
nivo-website Configuration

@scherler
Copy link
Contributor Author

@wyze can you comment on what is missing to make it into this repository?

@wyze
Copy link
Contributor

wyze commented May 25, 2021

Is there a reason this is needed? We have only had tsconfig files for when we convert the package to Typescript.

@scherler
Copy link
Contributor Author

It triggers the generation of the types

nivo/Makefile

Line 164 in 93943b8

@if [ -f "./packages/${*}/tsconfig.json" ]; \
so when you have a type based project you can use the lib with type support.

@wyze
Copy link
Contributor

wyze commented May 29, 2021

This was included with #1503.

@wyze wyze closed this May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants