feat(legends): migrate package to typescript

[wyze]

Close #1221
Close #1321

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ebfcc21:

Sandbox	Source
nivo	Configuration
nivo-website	Configuration
@nivo/pie TypeScript (forked)	Issue #1321
@nivo/pie TypeScript (forked)	Issue #1321

[jamesdh]

Ultimately I just added a default...

data: [], 
padding: 0

to each of my legend definitions. This got things building again and worked for everything but my line charts which still render but no longer show any legends.

[jamesdh]

Is requiring a Datum[] here right? I can't find anything in the Legends guide or in the storybooks demonstrating the use of this or explaining what it's for. This and the required padding above both broke every one of my charts.

[jamesdh]

Similarly, I never used the padding prop before and can't find any form of documentation describing how/what it is used for. Should this really be required?

[wyze]

This got things building again and worked for everything but my line charts which still render but no longer show any legends.

https://github.com/plouc/nivo/blob/master/packages/line/src/Line.js#L193

You have to exclude data from legend prop or it will use it. Looking at the previous props, they should have been not required. Sorry about that.

[jamesdh]

@wyze cool, I wasn't sure if you'd see this post-merge review :)

You have to exclude data from legend prop or it will use it.

Yea, unfortunately that triggers a typescript error since it's required, and so removing it causes the build to fail compilation.