Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SVG bar chart accessibility #1719

Merged
merged 14 commits into from
Aug 14, 2021
Merged

Improve SVG bar chart accessibility #1719

merged 14 commits into from
Aug 14, 2021

Conversation

plouc
Copy link
Owner

@plouc plouc commented Aug 13, 2021

  • Add support for various aria attributes to the SVG bar chart
  • Add support for various aria attributes to the core SVG wrapper
  • Mark SVG defs as hidden for screen readers
  • Make bar items focusable and trigger tooltip when focused
  • Use a single React hook to handle both bar SVG and Canvas implementations
  • Improve the accessibility of the website component tabs used to switch between chart/code/data
  • Allow markdown for components' help content
  • Do not use target="_blank" for links in markdown as it's generally considered not to be the best practice
  • Update caniuse-lite

@plouc plouc changed the title Bar a11y Improve SVG bar chart accessibility Aug 13, 2021
@plouc plouc self-assigned this Aug 13, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 14, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c48e43f:

Sandbox Source
nivo Configuration
nivo-website Configuration

@plouc plouc added a11y 📊 bar @nivo/bar package labels Aug 14, 2021
@plouc plouc mentioned this pull request Aug 14, 2021
@plouc plouc marked this pull request as ready for review August 14, 2021 08:03
@plouc plouc requested a review from wyze August 14, 2021 08:06
@plouc plouc merged commit 53811a5 into master Aug 14, 2021
@plouc plouc deleted the bar-a11y branch August 14, 2021 21:57
@bradlocking
Copy link

Hey Raphaël - Thanks for adding accessibility support to the bar chart component! We're currently working with a few other charts (Pie, Sunburst) and was wondering your thoughts on the complexity of getting broader accessibility support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y 📊 bar @nivo/bar package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants