Modifying Radar's Axis to be drawn by Axis.domain.line of the Theme #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GoodGoodJM, that's expected, this is the equivalent of the cartesian grid, not an axis. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
But there's a bug in the current implementation, should be |
|
ok but, if use |
|
@GoodGoodJM, yes, both are part of the grid, it's the same behavior as other charts, using axis is not correct. We could add another option to disable those. |
|
Thank you for this fix @GoodGoodJM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Radar's Axis is not currently being drawn by referring to the theme incorrectly.
Modify to draw axis using
theme.axis.domain.line.