RadialBar: Utilize defs/fill, modeled after Bar implementation #1957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use the patterned fill seen in https://nivo.rocks/marimekko/ for my use of ResponsiveRadialBar but noticed that
defs
andfill
props were not expected in the RadialBarSvgProps type nor the implementation to pass them along to SvgWrapper in RadialBar the way that Bar does. This PR adds that implementation in a similar way.Intermediate commits show I was initially pursuing this as Bar does by having
bindKeys
do a targetKey ofdata.fill
(https://github.com/plouc/nivo/blob/master/packages/bar/src/Bar.tsx#L268) but it felt more appropriate to instead avoid polluting incoming data and instead targetfill
at the root ComputedBar. I'd be fine with either approach if one is preferred.Note that the test suite fails on packages/scatterplot/tests/ScatterPlot.test.tsx but I believe these failures predate this proposal.