-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(legends): improve legends support #224
Conversation
plouc
commented
Jun 5, 2018
•
edited
Loading
edited
- add ability to handle mouseEnter/mouseLeave/click Legend Series Toggle #196, Is there a way to interact with the legend? #221
- add support for legends on Bubble Legend for nivo/ResponsiveBubble #181
- add support for legends on Waffle Legend for nivo/ResponsiveWaffle #226
- add ability to pass custom legend data to Bar custom legend text in BarChart #204
9405815
to
5f5a906
Compare
5f5a906
to
37ca0d9
Compare
Thanks for the great work. This PR will really help a lot of us. When do you think we can have this? @plouc |
This PR sounds very good! It is possible to pass custom Rects, like for the bar chart passing customBar? |
@ArtieReus, you mean custom symbols? |
@plouc yes, simbols. I need to select items from the legend to filter the chart. |
Is there any chance this will be merge? |
@ArtieReus custom symbols have been implemented. |
I've split this PR, |
so,how can I test this feature。I can't still see anything changed in this PR。 |
hi,@plouc , i finally manage to run this feature。but I still have problem to toggle series show/hide。 so,what‘s your suggestion? |
@wulu, I plan to add support for passing legend data instead of guessing it from the data itself, it should work, however I don't know when I'll be able to do so as I already have some ongoing features. |
it seems interesting。how about create a demo,and i am willing to take it to action? |
Will this PR contain any documentation for the Effects part of the legends? it seems to be missing from the Api docs. would greatly appreciate it. |
I've kept this PR to be able to pick features from it, however it won't be merged. |
I'm excited for this change to be available Edit: For more clarity (since I received some eye emojis, haha, please forgive! @rtroncoso @StanislavVoronov ): Clarifying:
So that if I decide to "toggle" my data (by removing one of the id's and its relevant data) - it won't remove a legend entry as a consequence of my data being removed. (Please let me know if in fact this legend data change has been pushed - I may very well have overlooked this - such that I can specify my array of legends regardless of what data I have passed in) I was excited to perhaps have something similar to Waffle - toggle series via Legend on click handler If there is already an existing work around you guys know of, with regards to toggling data series without losing legend. I'd be grateful to see your recommendation :) Kind regards and all the best |
Maybe you can add prop for custom legend and just pass all props you pass now into your legend to this custom render prop |
Is there a way to customize/edit the legend for the pie chart as well? @plouc Scenario: Sample Data Desired Output |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
This feature would be very useful. Please prioritize when possible. Thank you! |
Would be nice to have possibility to add another dataFrom for barChart legend |