Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/website/bar add legends fix #2282

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

Nanak360
Copy link
Contributor

@Nanak360 Nanak360 commented Apr 5, 2023

Clicking the Add Legend button on the bar page crashes the entire website as shown bellow
Tab-1680499869883-website

Bellow is the error message that we see when clicking the Add Legend button on dev env.
Tab-1680499836483-with error

Idealy a new legend group should be added. This PR has the fix for that.
Tab-1680499765293-proper

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bbae804:

Sandbox Source
nivo Configuration

Copy link
Owner

@plouc plouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plouc plouc merged commit f987fa6 into plouc:master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants