-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firstWeekday attr to calendar/TimeRange #2299
Add firstWeekday attr to calendar/TimeRange #2299
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b46a2ce:
|
Hi @plouc, is there anything else you'd want me to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @yzalvov, nope, LGTM, will merge as soon as tests pass, thank you! |
Hi @plouc, thanks for your prompt reaction and thank you for the library! FYI:
|
I moved to vercel, but didn't update the DNS yet, you can see it here for now: https://nivo-nxi8sxerj-plouc.vercel.app/time-range/. Regarding the tooltip issue, I think it's an old issue due to a cyclic dependency ( |
DNS updated, it might take some time to propagate. |
Hi @plouc, thanks so much for the library by the way 🤓 Helps a lot.. Just checking, is the broken tooltip situation resolved? If not, could you share a link to the issue please? |
So that Monday could be first.