shiftArray in calendar/src/compute/timeRange.ts should not mutate its argument

[wirhabenzeit]

This is a proposed fix for #2419

The function shiftArray mutates ARRAY_OF_WEEKDAYS which results in a wrong week day display in certain situations.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nivo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 25, 2023 0:10am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 91a4b8d:

Sandbox	Source
nivo	Configuration

[ordruk]

Alternatively, you can create a new array and build it based on the shifted elements from the original array.

function shiftArray<T>(arr: T[], x: number): T[] {
    if (!arr.length || !x) return arr;

    const newArr = [...arr];

    for (let i = 0; i < x; i++) {
        const shifted = newArr.shift() as T;
        newArr.push(shifted);
    }

    return newArr;
}

[ordruk]

However, I liked your fix 🙏