Add mesh to bump chart #2496
Add mesh to bump chart #2496
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2a64455:
|
|
@plouc Is this library still being mantained? I noticed there's a long list of open PRs that aren't getting merged nor reviewed. |
|
@santiperone, the answer is that it really depends on how much time I can find to work on the project, so while I want to keep the project alive, lately I could only spend a few hours here and there. |
|
@plouc I can imagine! Again, we're using this a lot and I'd be glad to help if you point me in the right direction. |
packages/bump/src/bump/hooks.ts
Outdated
| const point: BumpPoint<Datum, ExtraProps> = { | ||
| ...rawPoint, | ||
| serie, | ||
| isActive: activeSerieIds.includes(serie.id), | ||
| isInactive: activeSerieIds.length > 0 && !activeSerieIds.includes(serie.id), | ||
| isActive: activePointIds.includes(serie.id), |
There was a problem hiding this comment.
Shouldn't this check be on the point id rather than the series?
There was a problem hiding this comment.
Yeah I actually messed up here, i guess I made the changes without thinking too much about it.
I'll rollback this to just check the active serie.
Adding the activePoint opens up a lot of possibilities in terms of styling as well though.
There was a problem hiding this comment.
Open to ideas here, for now I think it should be fine to just follow the series for the active point styles
@santiperone, I reviewed the PR, regarding the lock file, could you please try to take the one from the master, using the new pnpm version specified in the main package.json file? |
|
@plouc I added some changes addressing your comments, I don't think it's quite ready yet but it's getting closer. |
|
@santiperone, sorry for the wait, and thank you for this addition, I'm going to merge as is, try it locally, and adjust myself, if necessary. |
|
@santiperone, I'll handle the adjustments in #2572. |
Hi! At my company we were needing the ability to show point-specific tooltips within a Bump chart. I ended up copying the bump component into our codebase to cover the use case, but thought others might find this useful as well.
The PR basically just adds a mesh layer and triggers the interactivity from the lines to the mesh (while still updating the activeSeries to keep behaviours as is).
Default behaviour for the component should remain the same.
Still not so convinced on the API decisions I made with tooltip and the handlers. And maybe instead of 'tooltipAchor' using useMesh as the line component does would be better.
I'm open to ideas and suggestions on this matter, and I can update the changes once we reach common ground there.