fix(sankey): update onClick types in sankey chart to respect generics #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b0a2406:
|
This was referenced Mar 8, 2024
sebald
referenced
this pull request
in sebald/pattern-analyzer
Mar 10, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@nivo/axes](https://togithub.com/plouc/nivo) ([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/axes)) | [`0.84.0` -> `0.85.1`](https://renovatebot.com/diffs/npm/@nivo%2faxes/0.84.0/0.85.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@nivo/bar](https://togithub.com/plouc/nivo) ([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/bar)) | [`0.84.0` -> `0.85.1`](https://renovatebot.com/diffs/npm/@nivo%2fbar/0.84.0/0.85.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@nivo/core](https://togithub.com/plouc/nivo) ([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/core)) | [`0.84.0` -> `0.85.1`](https://renovatebot.com/diffs/npm/@nivo%2fcore/0.84.0/0.85.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@nivo/line](https://togithub.com/plouc/nivo) ([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/line)) | [`0.84.0` -> `0.85.1`](https://renovatebot.com/diffs/npm/@nivo%2fline/0.84.0/0.85.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@nivo/pie](https://togithub.com/plouc/nivo) ([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/pie)) | [`0.84.0` -> `0.85.1`](https://renovatebot.com/diffs/npm/@nivo%2fpie/0.84.0/0.85.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@nivo/scatterplot](https://togithub.com/plouc/nivo) ([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/scatterplot)) | [`^0.84.0` -> `^0.85.0`](https://renovatebot.com/diffs/npm/@nivo%2fscatterplot/0.84.0/0.85.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@nivo/swarmplot](https://togithub.com/plouc/nivo) ([source](https://togithub.com/plouc/nivo/tree/HEAD/packages/swarmplot)) | [`^0.84.0` -> `^0.85.0`](https://renovatebot.com/diffs/npm/@nivo%2fswarmplot/0.84.0/0.85.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>plouc/nivo (@​nivo/axes)</summary> ### [`v0.85.1`](https://togithub.com/plouc/nivo/releases/tag/v0.85.1) [Compare Source](https://togithub.com/plouc/nivo/compare/v0.85.0...v0.85.1) #### What's Changed - Tooltip: avoid a flash effect and weird initial transition by [@​DimaAmega](https://togithub.com/DimaAmega) in [https://github.com/plouc/nivo/pull/2480](https://togithub.com/plouc/nivo/pull/2480) - feat(deps): upgrade d3-scale due to vulnerability by [@​plouc](https://togithub.com/plouc) in [https://github.com/plouc/nivo/pull/2531](https://togithub.com/plouc/nivo/pull/2531) #### New Contributors - [@​DimaAmega](https://togithub.com/DimaAmega) made their first contribution in [https://github.com/plouc/nivo/pull/2480](https://togithub.com/plouc/nivo/pull/2480) **Full Changelog**: plouc/nivo@v0.85.0...v0.85.1 ### [`v0.85.0`](https://togithub.com/plouc/nivo/releases/tag/v0.85.0) [Compare Source](https://togithub.com/plouc/nivo/compare/v0.84.0...v0.85.0) #### What's Changed - refactor default props to fix error message by [@​andre19980](https://togithub.com/andre19980) in [https://github.com/plouc/nivo/pull/2452](https://togithub.com/plouc/nivo/pull/2452) - fix(sankey): update onClick types in sankey chart to respect generics by [@​stas-demydiuk](https://togithub.com/stas-demydiuk) in [https://github.com/plouc/nivo/pull/2509](https://togithub.com/plouc/nivo/pull/2509) - chore: upgrade d3-color and d3-scale-chromatic by [@​icco](https://togithub.com/icco) in [https://github.com/plouc/nivo/pull/2466](https://togithub.com/plouc/nivo/pull/2466) - Fix: add initial property for truncateTickAt by [@​scalabw](https://togithub.com/scalabw) in [https://github.com/plouc/nivo/pull/2504](https://togithub.com/plouc/nivo/pull/2504) - fix tooltip default color by [@​scalabw](https://togithub.com/scalabw) in [https://github.com/plouc/nivo/pull/2521](https://togithub.com/plouc/nivo/pull/2521) - Touch crosshair for line graphs by [@​WilliamABradley](https://togithub.com/WilliamABradley) in [https://github.com/plouc/nivo/pull/2524](https://togithub.com/plouc/nivo/pull/2524) - fix(marimekko): use readonly arrays for props as the library does not modify them by [@​pcorpet](https://togithub.com/pcorpet) in [https://github.com/plouc/nivo/pull/2493](https://togithub.com/plouc/nivo/pull/2493) - fix(line): use readonly arrays for props as the library does not modify them by [@​pcorpet](https://togithub.com/pcorpet) in [https://github.com/plouc/nivo/pull/2494](https://togithub.com/plouc/nivo/pull/2494) - Fix (peer) dependencies by [@​marvinruder](https://togithub.com/marvinruder) in [https://github.com/plouc/nivo/pull/2528](https://togithub.com/plouc/nivo/pull/2528) #### New Contributors - [@​andre19980](https://togithub.com/andre19980) made their first contribution in [https://github.com/plouc/nivo/pull/2452](https://togithub.com/plouc/nivo/pull/2452) - [@​stas-demydiuk](https://togithub.com/stas-demydiuk) made their first contribution in [https://github.com/plouc/nivo/pull/2509](https://togithub.com/plouc/nivo/pull/2509) - [@​icco](https://togithub.com/icco) made their first contribution in [https://github.com/plouc/nivo/pull/2466](https://togithub.com/plouc/nivo/pull/2466) - [@​scalabw](https://togithub.com/scalabw) made their first contribution in [https://github.com/plouc/nivo/pull/2504](https://togithub.com/plouc/nivo/pull/2504) - [@​WilliamABradley](https://togithub.com/WilliamABradley) made their first contribution in [https://github.com/plouc/nivo/pull/2524](https://togithub.com/plouc/nivo/pull/2524) - [@​marvinruder](https://togithub.com/marvinruder) made their first contribution in [https://github.com/plouc/nivo/pull/2528](https://togithub.com/plouc/nivo/pull/2528) **Full Changelog**: plouc/nivo@v0.84.0...v0.85.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sebald/pattern-analyzer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced May 21, 2024
This was referenced May 26, 2024
This was referenced Jun 3, 2024
This was referenced Jun 3, 2024
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed to address a typing issue when custom types for Node and Link are not passed into the onClick handler of sankey chart and replaced with the
DefaultNodeandDefaultLinkinstead